Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: update column_type for both vstreamer and rowstreamer in a thread safe manner #13285

Closed
wants to merge 3 commits into from
Closed

VReplication: update column_type for both vstreamer and rowstreamer in a thread safe manner #13285

wants to merge 3 commits into from

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Jun 9, 2023 •
edited
Loading

Description

This PR fixes two bugs:

  1. The column_type vevent attribute was not consistently set in the rowstreamer.
  2. The code to update the column_type in the vstreamer was updating the vttablet engine's schema cache. This was incorrect both because it was racy with the schema tracker and because we should not be updating global objects while creating vreplication workflow table plans.

The code in #2 is thanks to @brendar and @austenLacy who detected this issue and fixed it in #13045. I have copied it over here so that both the rowstreamer and vstreamer fixes are in one place.

Related Issue(s)

Issue: #12981
Related PR: #13045

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 9, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 9, 2023
@github-actions github-actions bot added this to the v18.0.0 milestone Jun 9, 2023
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Jun 9, 2023
Merged
4 tasks
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 9, 2023
@rohit-nayak-ps rohit-nayak-ps force-pushed the rohit/thread-safe-vstreamer-plan branch 2 times, most recently from 700e2dd to 5e2d7bc Compare June 13, 2023 19:48
@rohit-nayak-ps
Use common code to update column_type for both vstreamer and rowstrea…
18611aa 
…m events in a thread-safe fashion. Fix related tests

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Use DBName and not keyspace name while getting extended field info!
ca2f438 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps force-pushed the rohit/thread-safe-vstreamer-plan branch from 5e2d7bc to e94f27f Compare June 13, 2023 20:19
@rohit-nayak-ps
Fix TestVStreamSharded
e94f27f 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Copy link
Contributor Author

The relevant commits from this PR were cherry-picked in #13045. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

Assignees
No one assigned
Labels
Component: VReplication Type: Bug
Projects
None yet
Milestone
v18.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rohit-nayak-ps